Skip to content

Conversation

jeromekelleher
Copy link
Contributor

@jeromekelleher jeromekelleher commented May 23, 2025

Fixes #401

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2025

Coverage Status

coverage: 98.292% (+0.006%) from 98.286%
when pulling d9b3ff8 on jeromekelleher:last-release-batch
into f6fbb1c on sgkit-dev:main.

@jeromekelleher jeromekelleher force-pushed the last-release-batch branch 2 times, most recently from 91fc110 to 7254cc7 Compare May 23, 2025 12:12
@jeromekelleher jeromekelleher marked this pull request as ready for review May 23, 2025 13:53
@jeromekelleher
Copy link
Contributor Author

OK, I think this is ready to go and we can tag the release.

I had to do a little work to get the plink conversion to work at scale, but I was getting very good performance on a large plink file after that. I think our numpy decoding approach works well and is nowhere near being a bottleneck.

This is a nice release now, lots of good stuff!

@jeromekelleher jeromekelleher requested a review from benjeffery May 23, 2025 13:56
Copy link
Contributor

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Let's release!

@jeromekelleher jeromekelleher added this pull request to the merge queue May 23, 2025
Merged via the queue into sgkit-dev:main with commit 806c836 May 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add console_script for plink2zarr
3 participants